Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monty hall problem #7

Merged
merged 18 commits into from Jul 4, 2022
Merged

Monty hall problem #7

merged 18 commits into from Jul 4, 2022

Conversation

mohitkyadav
Copy link
Owner

@mohitkyadav mohitkyadav commented Jul 3, 2022

  1. Create homepage
  2. Add react router
  3. Add monty hall problem (don't be confused by the simulate button, it works in the BE, doesn't trigger any fancy animations)

@aashutoshrathi I'll extract stuff to component in a different PR. This is already huge and I need to sleep.

@netlify
Copy link

netlify bot commented Jul 3, 2022

Deploy Preview for riddles-only4 ready!

Name Link
🔨 Latest commit 72031df
🔍 Latest deploy log https://app.netlify.com/sites/riddles-only4/deploys/62c29f6c4d35e50009cb4c81
😎 Deploy Preview https://deploy-preview-7--riddles-only4.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mohitkyadav mohitkyadav marked this pull request as ready for review July 3, 2022 21:32
@mohitkyadav mohitkyadav changed the title [WIP] Monty hall problem Monty hall problem Jul 3, 2022
@mohitkyadav mohitkyadav self-assigned this Jul 3, 2022
type="number"
id="noOfDoors"
value={noOfDoors}
onChange={(e) => setNoOfDoors(parseInt(e.target.value, 10))}
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

min = 3

Copy link
Collaborator

@aashutoshrathi aashutoshrathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just commit using clicks in my comments @mohitkyadav

src/components/Footer/Footer.tsx Outdated Show resolved Hide resolved
src/pages/MontyHall/MontyHall.tsx Show resolved Hide resolved
src/pages/MontyHall/MontyHall.tsx Show resolved Hide resolved
mohitkyadav and others added 3 commits July 4, 2022 10:05
Co-authored-by: Aashutosh Rathi <aashutoshrathi@gmail.com>
Co-authored-by: Aashutosh Rathi <aashutoshrathi@gmail.com>
Co-authored-by: Aashutosh Rathi <aashutoshrathi@gmail.com>
@mohitkyadav
Copy link
Owner Author

donzo! Many thanks @aashutoshrathi

Copy link
Collaborator

@aashutoshrathi aashutoshrathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this is official v1 of Monty Hall.
More improvements will come along the way

@aashutoshrathi aashutoshrathi merged commit cf1eab3 into main Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants