Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Code #1

Closed
wants to merge 1 commit into from
Closed

Optimize Code #1

wants to merge 1 commit into from

Conversation

AbdelrhmanSaid
Copy link

@AbdelrhmanSaid AbdelrhmanSaid commented Nov 28, 2022 •
edited

I tried to optimize the code, btw it can be optimized further.

  • Removed unused routes.
  • Separated Client / Server scripts.
  • Created functions to fetch data from Twitter, instead of repeating code multiple times.
  • Created a .env.example file where we can store Twitter's token.
  • Used Object.values instead of mapping through keys to get values.

⚠️ Important:
I didn't test this changes, but it should be working as expected.

@AbdelrhmanSaid
Changes:
80bc148 
- Removed unused routes.
- Separated Client / Server scripts.
- Created functions to fetch data from twitter, instead of repeating code multiple times.
- Created .env.example file where we can store twitter token.
- Used `Object.values` insted of mapping through keys to get values.
@AbdelrhmanSaid AbdelrhmanSaid changed the title Changes: Optimize Code Nov 28, 2022
@AbdelrhmanSaid AbdelrhmanSaid closed this by deleting the head repository Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@AbdelrhmanSaid