-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
number of tellers is computed incorrectly for finished stories #18
Comments
hmm, not as intuitive as I thought... |
I'd be careful introduction many similar numbers. How about: For running stories, display all participating users (as before), for finished stories the number of users that have contributed (as now). At least that's the numbers I'd be interested in. |
As I see it, we have 4 places where we show such numbers:
For 1., I'd definitely like to see the number of active players (so I have an idea when it might be my turn). For 2., number of contributors is fine, as is for 3. The best number for 4. is more difficult to decide since we might want to choose to be consistent with 1. or 3. Probably we could show both numbers? |
Something I currently see when viewing running story 55:
That number 0 is clearly wrong, since we know at least two people here. |
SInce we currently show number of people who contributed (i.e. wrote at least one part), for the first teller after the creator we get to see this, so it conforms to the current "specification". I think, however, that this behavior should be changed (see my comment above). |
I have now implemented my proposal from above. |
I think it's pretty cool now:-) |
It has to be the total number of tellers which contributed at least one part, not the number of tellers which have not left at the end of the story...
The text was updated successfully, but these errors were encountered: