Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

number of tellers is computed incorrectly for finished stories #18

Closed
mohrm opened this issue Jun 1, 2016 · 7 comments
Closed

number of tellers is computed incorrectly for finished stories #18

mohrm opened this issue Jun 1, 2016 · 7 comments
Labels

Comments

@mohrm
Copy link
Owner

mohrm commented Jun 1, 2016

It has to be the total number of tellers which contributed at least one part, not the number of tellers which have not left at the end of the story...

@mohrm mohrm added the bug label Jun 1, 2016
@mohrm mohrm closed this as completed in 65bb228 Jun 4, 2016
@mohrm
Copy link
Owner Author

mohrm commented Jun 4, 2016

hmm, not as intuitive as I thought...
Maybe also display the total number of tellers and the number of currently active tellers?

@mohrm mohrm reopened this Jun 4, 2016
@nomeata nomeata closed this as completed Jun 4, 2016
@nomeata
Copy link
Collaborator

nomeata commented Jun 4, 2016

I'd be careful introduction many similar numbers. How about: For running stories, display all participating users (as before), for finished stories the number of users that have contributed (as now). At least that's the numbers I'd be interested in.

@nomeata nomeata reopened this Jun 4, 2016
@ratefuchs
Copy link
Collaborator

As I see it, we have 4 places where we show such numbers:

  1. In the overview, table of running stories
  2. In the overview, table of finished stories
  3. On viewing a finished story
  4. On viewing a running story

For 1., I'd definitely like to see the number of active players (so I have an idea when it might be my turn). For 2., number of contributors is fine, as is for 3. The best number for 4. is more difficult to decide since we might want to choose to be consistent with 1. or 3. Probably we could show both numbers?

@qznc
Copy link
Collaborator

qznc commented Jun 4, 2016

Something I currently see when viewing running story 55:

(von DL und 0 weiteren Erzählern)
Diese Geschichte wird als nächstes von mheck01 weitergeschrieben.

That number 0 is clearly wrong, since we know at least two people here.

@ratefuchs
Copy link
Collaborator

ratefuchs commented Jun 4, 2016

Something I currently see when viewing running story 55:

(von DL und 0 weiteren Erzählern)
Diese Geschichte wird als nächstes von mheck01 weitergeschrieben.

That number 0 is clearly wrong, since we know at least two people here.

SInce we currently show number of people who contributed (i.e. wrote at least one part), for the first teller after the creator we get to see this, so it conforms to the current "specification". I think, however, that this behavior should be changed (see my comment above).

@ratefuchs
Copy link
Collaborator

I have now implemented my proposal from above.

@mohrm
Copy link
Owner Author

mohrm commented Jun 5, 2016

I think it's pretty cool now:-)

@mohrm mohrm closed this as completed Jun 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants