Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line separator --- will break all following # header font emphasising #4

Closed
MetaChuh opened this issue Mar 10, 2019 · 3 comments
Closed
Labels
bug Something isn't working

Comments

@MetaChuh
Copy link

MetaChuh commented Mar 10, 2019

hi @mohzy83

thanks for your new NppMarkdownPanel markdown viewer plugin.
i've just tested it and found two little issues:

  • if you use the line separator --- all following # h-lines will not be emphasised in font size.

  • a # h-lines is always seen as underlined, instead of just emphasising the size.

sample code to reproduce:

## test 1

---

## test 2

---

### test 3

sample result images:

current view (NppMarkdownPanel):
Imgur

expected view (MarkdownViewer++):
Imgur

ps: i really like your new plugin, because it scales ![image name](image.url) images at your markdown panel. 👍
(MarkdownViewer++ for example, keeps images 1:1 in size, cutting off larger images at the right edge, while NppMarkdownPanel is able to display the scaled, whole picture)

many thanks for your work.

greetings and best regards,
metachuh

@mohzy83
Copy link
Owner

mohzy83 commented Mar 11, 2019

Hi @MetaChuh,

I am happy you like my plugin. One of the reasons why I made this plugin, was to have a better HTML rendering engine than MarkdownViewer++. My plugin is using an embedded IE11 and the results are better compared to the HtmlRenderer-lib which is used by MarkdownViewer++. Thats why your images are scaled correctly ;)

The issue you have mentioned is related to CommonMark.NET. I will check if i can fix that in CommonMark.NET or if I have to change the C# MarkDown rendering library.

Best Regards,
Mohzy

@mohzy83 mohzy83 added the bug Something isn't working label Mar 11, 2019
@mohzy83
Copy link
Owner

mohzy83 commented Mar 27, 2019

So this was a style problem.
Fixed and tested with new release verison 0.4.0.

@mohzy83 mohzy83 closed this as completed Mar 27, 2019
@MetaChuh
Copy link
Author

very cool, thanks, i've just tried it out. 👍
i've seen you've already made the plugin list pull request too. 👍
let's hope it gets merged before the 7.6.5 release.

greetings and best regards,
metachuh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants