Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate output based on multiple input files #165

Closed
Beliar83 opened this issue Mar 6, 2023 · 6 comments
Closed

Generate output based on multiple input files #165

Beliar83 opened this issue Mar 6, 2023 · 6 comments
Labels
enhancement New feature or request help wanted Extra attention is needed probably-not

Comments

@Beliar83
Copy link

Beliar83 commented Mar 6, 2023

I am looking into the possibility to use Godot 4.0 directly with F#, without going through C# classes as base types that the source generator can pick up, and it seems like Myriad would be the best method for that.

One thing that I can see being a problem now would be that there needs to be a [<assembly:AssemblyHasScripts>] definition.
While it can be left empty as that and Godot will use reflection to look for types (though I have not checked if that works with F#) normally it has a list of script classes. For that last to work though I would need to be able to generate input on multiple files, which does not seem to be possible, or is at least undocumented.

@7sharp9
Copy link
Collaborator

7sharp9 commented Mar 14, 2023

Its currently not possible, I would be open to a contribution if you could explain the rules and parameters etc.

@7sharp9 7sharp9 added enhancement New feature or request help wanted Extra attention is needed NeedDocs labels Mar 14, 2023
@7sharp9
Copy link
Collaborator

7sharp9 commented Mar 31, 2023

So let me get this correct, you need to look at a list of assemblies and find those with AssemblyHasScripts then generate files based on something inside that assembly and bundle it into one file per assembly?

Why not just bundle them in one file with namespaces for the things generated, assuming the assemblies don't have namespace clashes.

@7sharp9
Copy link
Collaborator

7sharp9 commented Mar 31, 2023

Or is it that the generated stuff needs that attribute, maybe make the attribute conditional to something myriad generates if that's the case.

@7sharp9 7sharp9 removed the NeedDocs label Mar 31, 2023
@Beliar83
Copy link
Author

This attribute needs to be generated, and contain a list of types. It can only appear once for an assembly.
This is not important for this case any more, though, as it was decided to use a different approach which does not need the F# generators to generate this attribute.

@7sharp9
Copy link
Collaborator

7sharp9 commented Apr 2, 2023

So should I just close this if it is no longer of interest?

@Beliar83
Copy link
Author

Beliar83 commented Apr 2, 2023

Unless someone else needs it, sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed probably-not
Projects
None yet
Development

No branches or pull requests

2 participants