Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

threshold_selection_tool_from_labels_table does not work using spark #2188

Open
2 tasks done
guylissak opened this issue May 18, 2024 · 1 comment
Open
2 tasks done
Labels
bug Something isn't working

Comments

@guylissak
Copy link

What happens?

https://moj-analytical-services.github.io/splink/charts/threshold_selection_tool_from_labels_table.html

Hi this functionality of threshold_selection_tool_from_labels_table does not work when using spark linker.
same code works for me when using DuckDB

error:
ParseError: Invalid expression / Unexpected token. Line 1, Col: 14.
l.first_name�[4m�[0m = r.first_name

To Reproduce

Run this code using spark linker

https://moj-analytical-services.github.io/splink/charts/threshold_selection_tool_from_labels_table.html

OS:

Databricks

Splink version:

3.9.14

Have you tried this on the latest master branch?

  • I agree

Have you tried the steps to reproduce? Do they include all relevant data and configuration? Does the issue you report still appear there?

  • I agree
@guylissak guylissak added the bug Something isn't working label May 18, 2024
@RobinL
Copy link
Member

RobinL commented Jun 7, 2024

Thanks for the report

The characters �[4m�[0m are ANSI escape codes for terminal text formatting. Specifically:

  • �[4m is the ANSI escape code for enabling underline.
  • �[0m is the ANSI escape code for resetting all text attributes (including underline).

I think this is therefore likely to be a copy and paste problem, could be related to this:
#2018

I've tried copy pasting the duckdb code which works fine at my end.

Are you able to post a reproducible example using the Spark linker where this error occurs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants