Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: Introduce DataSharedFacetValue and MethodSharedFacetValue subtypes #113

Closed
xaviervia opened this issue Feb 28, 2023 · 1 comment
Closed

Feature request: Introduce DataSharedFacetValue and MethodSharedFacetValue subtypes #113

xaviervia opened this issue Feb 28, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@xaviervia
Copy link
Contributor

xaviervia commented Feb 28, 2023 •
edited

Moving forward, we don't want to mix and match methods and data in shared facets. We want to think of data facets as pure data, much like Redux state, and method facet as flat lists of available API calls from the remote.

Additionally, MethodSharedFacetValues could automatically do a .bind on the methods it includes, to avoid issues with selecting individual methods from the facet and losing the this reference.
@xaviervia xaviervia added the enhancement New feature or request label Feb 28, 2023
@pirelenito
Copy link
Member

Closing this as we are exploring better alternative APIs for shared facets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pirelenito @xaviervia