Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding release tag #57

Closed
hsmaan opened this issue Mar 15, 2021 · 2 comments
Closed

Adding release tag #57

hsmaan opened this issue Mar 15, 2021 · 2 comments

Comments

@hsmaan
Copy link

hsmaan commented Mar 15, 2021

Hi,

I was wondering if it's possible to add a release tag for the repo to build with conda. The package is not on a conda channel yet and building using conda skeleton cran https://github.com/mojaveazure/seurat-disk fails because of the lack of a tag and results in - Error: no tags found. The problem is detailed by this issue on the conda repo. Thank you.

@tessadgreen
Copy link

I was able to install seurat-disk directly from RStudio in a session launched from conda. This is surely the path to a future broken environment, but it works for now.

As a temporary fix, I also forked the current version and added a release tag (https://github.com/tessadgreen/seurat-disk), which does make it compatible with conda skeleton, though I didn't end up needing that method. I'm reluctant to make a pull request for it, given that @mojaveazure probably wants to manage their own releases, but it might work as a stopgap.

@hsmaan
Copy link
Author

hsmaan commented Apr 22, 2021

Thanks @tessadgreen , this is a great quick fix. I was able to use conda skeleton by forking and tagging the release on it.

Closing this for now as the temporary solution works.

@hsmaan hsmaan closed this as completed Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants