Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The appassembler-maven-plugin should not store configuration data in global static map #97

Open
dhoffer opened this issue Oct 25, 2019 · 0 comments

Comments

@dhoffer
Copy link

dhoffer commented Oct 25, 2019

The appassembler-maven-plugin should not store binFileExtensions in global static map as it causes the configuration of one module to affect all the other modules in the same build.

We have a large multi-module build where we use the appassembler-maven-plugin in about 30 modules. In all of these we were using the default bin file extension DEFAULT_UNIX_BIN_FILE_EXTENSION for many years. Then yesterday one new module was used where they needed to manually specify the file extension in that one new module.

However because this is loaded into a static map the changes in that one module now effect all the others. This should be changed that all configuration properties are per use of the plugin not globally across all modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant