Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release to support reproducible builds #296

Open
lucamolteni opened this issue Jan 22, 2024 · 3 comments
Open

New release to support reproducible builds #296

lucamolteni opened this issue Jan 22, 2024 · 3 comments

Comments

@lucamolteni
Copy link

To be published in apache, https://github.com/apache/incubator-kie-optaplanner requires reproducible builds. It seems like the current build is blocked by jaxb2-maven-plugin:3.1.0, here's the output of

man clean install
mvn artifact:check-buildplan
...
[ERROR] plugin without solution org.codehaus.mojo:jaxb2-maven-plugin:3.1.0, see https://github.com/mojohaus/jaxb2-maven-plugin
...

It seems like there are commit related to reproducible build such as #243 but in 3.1.0 it seems unsupported (see https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/codehaus/mojo/jaxb2-maven-plugin/README.md)

From local checking out the master branch it seems like the build plan correctly works and reproducible builds are supported.

Can you tell me when there will be a new release?

Thank you

@lucamolteni
Copy link
Author

Tagging @olamy as you did the last release

@hboutemy
Copy link
Member

@lucamolteni #243 is about having jaxb maven plugin itself reproducible
it is not about the plugin to produce reproducible output

I just tested Kie Optaplanner build reproducibility locally:

mvn clean install -DskipTests && mvn clean package -DskipTests artifact:3.5.1-SNAPSHOT:compare -Dcompare.fail=false 

the only issues are with Quarkus-generated files

├── META-INF/quarkus-extension.properties
│ @@ -1,4 +1,4 @@
│  #Generated by extension-descriptor
│ -#Wed Jan 24 07:05:47 CET 2024
│ +#Wed Jan 24 07:09:42 CET 2024
│  deployment-artifact=org.optaplanner\:optaplanner-quarkus-deployment\:999-SNAPSHOT
│  provides-capabilities=org.optaplanner.optaplanner-quarkus
├── META-INF/quarkus-javadoc.properties
│ @@ -1,9 +1,9 @@
│  #
│ -#Wed Jan 24 07:05:47 CET 2024
│ +#Wed Jan 24 07:09:42 CET 2024
│  org.optaplanner.quarkus.config.OptaPlannerRuntimeConfig.solver=During run time, this is translated into OptaPlanner's {@link SolverConfig}\nruntime properties.

but your use of JAXB2 does not have any issue

@hboutemy
Copy link
Member

starting an effort to better understand this jaxb2 reproducible output and clarify where to solve it (a maven plugin or a jaxb2 implementation): jvm-repo-rebuild/reproducible-central#139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants