Marked XjcMojo as thread safe. #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArgumentBuilder#getIndexForFlag to prevent threading issues (concurrent update). Closes #81
|
Are you going to merge this pull request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your plugin is thread safe: I execute it in my projects in parallel execution mode for several years now. I checked the code and found only one part that could be influenced by multiple threads:
In the class ArgumentBuilder there is one point where a List that is synchronized within blocks using a lock object (could be the manipulated object itself by the way) could be read during an updated. I added a synchronized block for it.
I checked the static class members of XjcMojo and saw, that each of it is immutable. There is no clear sign, that this plugin is not thread safe. It's worth to mark it thread-safe.