Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle delimiter usage #112

Open
koen-serneels opened this issue Oct 29, 2017 · 1 comment
Open

Toggle delimiter usage #112

koen-serneels opened this issue Oct 29, 2017 · 1 comment

Comments

@koen-serneels
Copy link

koen-serneels commented Oct 29, 2017

Hi. When the plugin adds licenses, delimiters are inserted so the plugin knows where to update the license in case of updates. Afaik there are 3 configuration options to change the delimiters but not to disable them altogether. Personally I find the delimiters disturbing and unnecessary. For example, when adding the license before the package declaration or between package and imports, it make sense to simply have the chosen comment format (javadoc, ...) as delimiter. In nearly all cases there is no other stuff than licensing information on those two locations anyway. Also, when no delimiters are used inside the template, the template could then be replaced each time completely. Would it make sense to add such an option? (it could be "false" by default to keep it backward compatible) Or is there another way maybe that I just insert my predefined text in each source file (making use of the configured comment style) but already without any delimiters? ....

@ppalaga
Copy link
Contributor

ppalaga commented Jan 4, 2019

A PR with an integration test is welcome.

In the meantime, you may want to consider using com.mycila:license-maven-plugin that adds no clutter to the license header.

[1] https://github.com/mycila/license-maven-plugin

@ppalaga ppalaga added this to the Backlog milestone Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants