#673: Fixing NPE in UseDepVersionMojo caused by PatternIncludesArtifactFilter expecting a non-null classifier when using wildcards #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esArtifactFilter expecting a non-null classifier when using wildcards
jarmoniuk
commented
Sep 7, 2022
|
@slawekjaranowski please review |
|
For reference https://issues.apache.org/jira/browse/MSHARED-1104 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for the NPE: the new version of maven-common-artifact-filters, class
PatternIncludesArtifactFilters(line 593) expects the "artifactoid" to return a non-null value for every field when the pattern contains a wildcard character.The "artifactoid" is a functional interface basically returning the desired segment (coordinate in the code) of the artifact. The classifer is not set, hence equal null; this leads to NPE.