upload-single skip option removed 1.0 -> 2.0.0

[jessefarinacci]

Please bring back this option. It is valuable for specifying common configuration in higher level poms and then unskipping in a wide number of child poms. DRY. Please bring back the option, it is nice. :) Thanks.

[jessefarinacci]

bash$ mvn help:describe -Dplugin=org.codehaus.mojo:wagon-maven-plugin:1.0 -Dgoal=upload-single -Ddetail

wagon:upload-single
  Description: Upload a single file with option to change name
  Implementation: org.codehaus.mojo.wagon.UploadSingleMojo
  Language: java

  Available parameters:

    fromFile
      Required: true
      User property: wagon.fromFile
      Path to a local file to be uploaded

    serverId (Default: serverId)
      User property: wagon.serverId
      settings.xml's server id for the URL. This is used when wagon needs extra
      authentication information.

    skip (Default: false)
      User property: wagon.skip
      When true, skip the execution.

    toFile
      User property: wagon.toFile
      Relative path to the URL. When blank, default to fromFile's file name.

    url
      Required: true
      User property: wagon.url
      URL to upload to or download from or list. Must exist and point to a
      directory.

versus

bash$ mvn help:describe -Dplugin=org.codehaus.mojo:wagon-maven-plugin:2.0.0 -Dgoal=upload-single -Ddetail

wagon:upload-single
  Description: Upload a single file with option to change name
  Implementation: org.codehaus.mojo.wagon.UploadSingleMojo
  Language: java

  Available parameters:

    fromFile
      Required: true
      User property: wagon.fromFile
      Path to a local file to be uploaded.

    serverId (Default: serverId)
      User property: wagon.serverId
      settings.xml's server id for the URL. This is used when wagon needs extra
      authentication information.

    toFile
      User property: wagon.toFile
      Relative path to the URL. When blank, default to fromFile's file name.

    url
      Required: true
      User property: wagon.url
      URL to upload to or download from or list. Must exist and point to a
      directory.

[afel]

Same for "upload" goal

[dantran]

fixed at 4b4f1d3

[jpraet]

Any ETA on release 2.0.1?

[jpraet]

The fix was reverted again just before the 2.0.1 release? 4d67a10

[dantran]

It was accidentally reverted due to javadoc annotation no longer support and failed 2.0.1 release build
will put it back in 2.0.2 soon

[dantran]

@jpraet please help to verify again 2.0.2 currently at staging repo https://oss.sonatype.org/content/groups/staging/

[jpraet]

@dantran yes, it works with the 2.0.2

[cdprete]

Hi.
I think the property is evaluated too early.

I've a (in version 2.0.2) a configuration like

<plugin>
                        <groupId>org.codehaus.mojo</groupId>
                        <artifactId>wagon-maven-plugin</artifactId>
                        <executions>
                            <execution>
                                <id>deploy-rpm</id>
                                <phase>deploy</phase>
                                <goals>
                                    <goal>upload-single</goal>
                                </goals>
                                <configuration>
                                    <skip>${rpm.build.skip}</skip>
                                    <fromFile>${rpm.file-path}</fromFile>
                                    <serverId>${rpm.repository.id}</serverId>
                                    <url>${rpm.repository.url}/${rpm.file-name}/${rpm.file-version}</url>
                                </configuration>
                            </execution>
                        </executions>
                    </plugin>

where rpm.build.skip is dynamically set in a Groovy script. I've other plugins reading the exact same property in other phases and they're all skipped correctly but the wagon-maven-plugin.

[2022-04-01T12:27:39.537Z] [ERROR] Failed to execute goal org.codehaus.mojo:wagon-maven-plugin:2.0.2:upload-single (deploy-rpm) on project parent: The parameters 'fromFile' for goal org.codehaus.mojo:wagon-maven-plugin:2.0.2:upload-single are missing or invalid -> [Help 1]

where such property (as well as the others) are unset since I want to skip the execution.