Signing of the JNLP file inside the main jar? (MWEBSTART-176)

[victornoel]

Hi,

There was the issues MWEBSTART-176 that proposed to include the generated JNLP file inside the main jar before signing it.

Is there any plan to implement that? I think that would be great, and it would combine very well with the need expressed in #12 !

Here is the previous content of the issue:

It would be very nice to have support for signing the JNLP file as part of the maven plugin. The installation appears more trustworthy for JNLP-signed applications. It can be done now, but it includes several error prone manual steps.

The signing process is really very simple. The final JNLP file should be included in the main jar file as /JNLP-INF/APPLICATION.JNLP before the jar file is signed.

I guess the following tasks have to be taken care of:

• Add support for a new configuration setting for the plugin in the pom file(boolean signJnlp)
• Add the new setting in AbstractBaseJnlpMojo.java or AbstractJnlpMojo.java with default value set to false
• Modify the execute() method in AbstractJnlpMojo.java so that the final JNLP file is generated before the main jar file is signed. For example move the call to generateJnlpFile( getWorkDirectory()) right after the call to processDependencies().
• Implement injection of the final JNLP file into the main jar file
  • Identify the main jar file and extract it
  • Copy the generated jnlp file to the extracted directory under /JNLP-INF/APPLICATION.JNLP
  • Create an new main jar archive with the modified content
  • Copy the main jar file into the lib location for further processing (packing and signing)

When using no codebase (1.6.0_u18+), the JNLP file should not be signed due to a bug in Java 6 and 7.

[tchemit]

#12 was merged :) could you confirm that everything is ok for you ? If so could you close this issue, I will sonne try to do a new release of this plugin. Thanks.

[victornoel]

@tchemit I'm sorry, I don't have the mean and opportunity to test that nowadays (I'm not even sure I remember what I exactly had in mind when I opened this issue), so this will have to be checked by someone else.

Sorry again, if you need me to close the issue anyway, tell me.

[tchemit]

yep if you can close, Iam trying to clean up roadmap, hard task... :)--Enjoy and ShareTony Chemit On févr. 20 2018, at 5:38 pm, Victor Noël <notifications@github.com> wrote: @tchemit I'm sorry, I don't have the mean and opportunity to test that nowadays (I'm not even sure I remember what I exactly had in mind when I opened this issue), so this will have to be checked by someone else. Sorry again, if you need me to close the issue anyway, tell me. —You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.