Add clearer error when more than one oneOf rule matched

[karenetheridge]

fixes #164.

[jhthorsen]

Ah. I think I misunderstood #164. Thanks for clearing it up with this PR.

Would it be possible to let the user know which rules that failed? Let’s say something like “oneOf rules 0, 2, 5 match.”.

[karenetheridge]

Would it be possible to let the user know which rules that failed?

Yes, that should be possible with a bit of juggling. I'll push an update.

[jhthorsen]

Don’t do it if it’s a lot of hassle/lines of code.

[karenetheridge]

It would be a few lines of code -- we can get all the failure rules numbers by doing

-    push @expected, $schema_type;
+    push @expected, [$i, $schema_type];

and then @failed = sort {$a <=> $b} map $_->[0], @errors, @expected, but then we need to subtract that list from 0..@rules-1 to get the rules that passed. I don't see how to do it without at least one extra local variable :)

[karenetheridge]

I pushed another commit that uses the indexes of the matching oneOf rules, which you can squash if you like it, or ignore if you don't :)

[karenetheridge]

I force-pushed a much nicer change for adding passing indexes. :)

[jhthorsen]

Can you do this instead?

@@ -731,8 +731,7 @@ sub _validate_one_of {
   $self->_report_schema($path, 'oneOf', $rules) if REPORT;
   local $self->{grouped} = $self->{grouped} + 1;

-  my $i = 0;
-  my @passed;
+  my ($i, @passed) = (0);
   for my $rule (@$rules) {
     my @e = $self->_validate($_[1], $path, $rule) or push @passed, $i and next;
     my $schema_type = _guess_schema_type($rule);
@@ -751,13 +750,11 @@ sub _validate_one_of {
     $self->_report_errors($path, 'oneOf', \@e);
   }

-  return if @errors + @expected + 1 == @$rules;
-  my $expected = join '/', _uniq(@expected);
+  return if @passed == 1;
   return E $path, [oneOf => 'all_rules_match'] unless @errors + @expected;
-  return E $path, [oneOf => 'n_rules_match', join(', ', @passed)]
-    if @passed > 1;
-  return E $path, [oneOf => type => $expected => $type] unless @errors;
-  return _add_path_to_error_messages(oneOf => @errors);
+  return E $path, [oneOf => n_rules_match => join ', ', @passed] if @passed;
+  return _add_path_to_error_messages(oneOf => @errors) if @errors;
+  return E $path, [oneOf => type => join('/', _uniq(@expected)), $type];

[karenetheridge]

and done!

[jhthorsen]

Awesome! 👍