fix if-then-else, anyOf, dependencies #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhthorsen
requested changes
Feb 14, 2020
| push @errors, | ||
| $self->_validate_any_of($to_json ? $$to_json : $_[1], $path, $rules); | ||
| } | ||
| elsif ($rules = $schema->{oneOf}) { | ||
|
|
||
| if (my $rules = $schema->{oneOf}) { |
There was a problem hiding this comment.
Side note: I really hope nobody actually uses this. Seems like a too complicated schema to understand.
There was a problem hiding this comment.
a combination of oneOf, anyOf and allOf all at the same time? hey, you never know :D
| push @errors, | ||
| $self->_validate_one_of($to_json ? $$to_json : $_[1], $path, $rules); | ||
| } | ||
|
|
||
| if ($schema->{if}) { |
karenetheridge
force-pushed
the
ether/if-anyOf-dependencies
branch
2 times, most recently
from
063dce5
to
3c314d9
Compare
jhthorsen
requested changes
Feb 14, 2020
lib/JSON/Validator/Error.pm
Outdated
| @@ -35,6 +35,7 @@ our $MESSAGES = { | |||
| maxProperties => 'Too many properties: %3/%4.', | |||
| minProperties => 'Not enough properties: %3/%4.', | |||
| required => 'Missing property.', | |||
| dependencies => 'Missing property: Dependee: %3.', | |||
There was a problem hiding this comment.
Too many colons. How about "Missing property. Dependee: %3."
karenetheridge
force-pushed
the
ether/if-anyOf-dependencies
branch
2 times, most recently
from
8b5ab16
to
e759a15
Compare
karenetheridge
force-pushed
the
ether/if-anyOf-dependencies
branch
from
e759a15
to
8ea23ad
Compare
|
Awesome 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixes bugs: #190, #196, #192 where various keywords were not fully supported
Motivation
see their respective issues for background and references
I am not quite sure what error messages are best: "Missing property" was already being used by the 'required' keyword, and it's not great to have two different errors sharing the same message, so I made the 'required' error "Missing required property", so 'dependencies' can have "Missing dependent property". However, changing an existing error message might break unit tests in downstream code.