Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"3rd thursday this November" is a day out. #17

Closed
wjessop opened this issue Oct 28, 2010 · 1 comment
Closed

"3rd thursday this November" is a day out. #17

wjessop opened this issue Oct 28, 2010 · 1 comment
Labels

Comments

@wjessop
Copy link

wjessop commented Oct 28, 2010

Trying a couple of other months these all work fine:

ruby-1.9.2-p0 > Chronic.parse('3rd thursday this October')
=> 2010-10-21 12:00:00 +0100
ruby-1.9.2-p0 > Chronic.parse('3rd thursday this December')
=> 2010-12-16 12:00:00 +0000

However November is a day out, it should be the 18th:

ruby-1.9.2-p0 > Chronic.parse('3rd thursday this November')
=> 2010-11-19 11:00:00 +0000

I get the same error in ruby 1.9.2p0 and 1.8.7p174. The only weird datey thing in the near future is a switch back from DST (GMT +1) to GMT in the next few days. December however works fine:

ruby-1.9.2-p0 > Chronic.parse('3rd thursday in December')
=> 2010-12-16 12:00:00 +0000

@dannyb
Copy link

dannyb commented Nov 11, 2010

I am running into a very similar problem. In some cases it works fine, but under some situations it goes off by a day. I created a gist showing the different scenarios that work and don't work.

It does appear to do with the switch of PST/PDT.

https://gist.github.com/672230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants