Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OmNomNum #352

Open
JesseBuesking opened this issue Feb 14, 2017 · 2 comments
Open

Use OmNomNum #352

JesseBuesking opened this issue Feb 14, 2017 · 2 comments

Comments

@JesseBuesking
Copy link

JesseBuesking commented Feb 14, 2017

Hey all!

I just created the library OmNomNum, a C extension that I aim to use as a replacement for Numerizer. OmNomNum currently does not support fractions, so it's not a 100% replacement for Numerizer just yet.

The main purpose of adding this issue was to let you know that my library exists. Ideally other Rubyists using this library could benefit from OmNomNum. Let me know if you're interested in possibly working together to add support for OmNomNum to Chronic. I've read recent issues and I realize that there's a rewrite underway for Chronic, but there's immediate benefit to using OmNomNum within Chronic in it's current version until the rewrite is finished.

If you have any questions, just let me know.

👍

@TheKidCoder
Copy link

While I see the merit in adding this feature - I would just like to cast my vote against it as any reliance on a cext would limit Chronic's portability. We use Chronic on jruby, for example.

@JesseBuesking
Copy link
Author

@TheKidCoder Ideally this wouldn't replace anything within Chronic but would be offered as an alternative implementation of the Numerizer logic. For example, we could have a gem that simply monkey patches Chronic allowing anyone who is using MRI to simply include the gem to get the benefits.

I really posted this to raise awareness of OmNomNum and to see what the community thinks is the right approach to using it within Chronic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants