Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated styles without fixed widths #330

Closed
alexanderttalvarez opened this issue May 2, 2022 · 3 comments
Closed

Updated styles without fixed widths #330

alexanderttalvarez opened this issue May 2, 2022 · 3 comments

Comments

@alexanderttalvarez
Copy link

After updating to the last version, our admin panel changed its style. We identified that in this commit 6e38fc6, some classes were updated.

For example, .torch-panel changed from:

.torch-panel {
    max-width: 800px;
    border: 2px solid #eee;
    padding: 25px;
}

to

.torch-panel {
    border: 2px solid #eee;
    flex: 1;
    padding: 25px;
}

or .torch-container changed from:

html .torch-container {
    width: calc(1325px + 15px + 15px);
    max-width: calc(100% - 30px);
    margin: 0 auto;
    padding-right: 15px;
    padding-left: 15px;
}

to

html .torch-container {
    margin: 0 auto;
    padding-left: 15px;
    padding-right: 15px;
}

Was that intended? After these changes, our admin panel takes the whole width of the page.

@cpjolicoeur
Copy link
Member

Yes, this was intended and some of the DOM/CSS changes are referenced in the UPGRADING.md file.

If you prefer the fixed with style, you can always override the CSS yourself with your own customization to revert back to fixed width. Many users already customize the Torch UI in their own CSS files (for things like colors, images, layout, etc...) and you can continue to use this mechanism, if you prefer, to use the older fixed-width formatting.

@alexanderttalvarez
Copy link
Author

Oh ok, we didn't notice the UPGRADING file. Thank you very much!

@cpjolicoeur
Copy link
Member

@alexanderttalvarez no problem. If you are interested in keeping the old fixed width feature, I'd be open to have a Pull Request made with those changes via a config :torch setting perhaps. Then when the generators can run,the config can be referenced to we can output flex-based, or fixed-width templates depending on users preference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants