Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

L2 weight regularisation in loss? #2

Closed
gooooloo opened this issue Nov 3, 2017 · 1 comment
Closed

L2 weight regularisation in loss? #2

gooooloo opened this issue Nov 3, 2017 · 1 comment

Comments

@gooooloo
Copy link
Contributor

gooooloo commented Nov 3, 2017

reversi-alpha-zero/src/reversi_zero/worker/optimize.py

Line 70 in 6468f5e

losses = [objective_function_for_policy, objective_function_for_value]

In the paper, there is a L2 weight regularisation in loss equation. Seems your implementation doesn't have it? ( please correct me if that regularisation is implied somewhere else. )
@gooooloo
Copy link
Contributor Author

gooooloo commented Nov 3, 2017

I see. It is in model.py. l2_reg.

@gooooloo gooooloo closed this as completed Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gooooloo