Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sliding windows? #24

Closed
saigamp opened this issue Oct 24, 2018 · 1 comment
Closed

Sliding windows? #24

saigamp opened this issue Oct 24, 2018 · 1 comment

Comments

@saigamp
Copy link

saigamp commented Oct 24, 2018

Hi,
It seems that windows doesn't slides in inMemory mode. Maybe is it a bug?
In InMemorySlidingWindowRequestRateLimiter.java line 136:
replace == by <=

Regards
@mokies
Copy link
Owner

mokies commented Apr 28, 2019

Thanks for calling this out, you are right. This seems to point to some fairly critical deficiencies in the tests. Have patched.

@mokies mokies closed this as completed Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mokies @saigamp