Skip to content
This repository has been archived by the owner on Mar 31, 2023. It is now read-only.

F-Droid #16

Closed
Poussinou opened this issue May 22, 2018 · 18 comments
Closed

F-Droid #16

Poussinou opened this issue May 22, 2018 · 18 comments

Comments

@Poussinou
Copy link
Contributor

Poussinou commented May 22, 2018

Hi,

Since this app is Apache v2 licensed, are you considering the fact to add it to F-Droid? There is a strong community behind.

Your app has already been requested here.

You can find some documentation here.

Otherwise, if you don't want to work on the inclusion of this app by yourself, would it be ok for you if someone else do it for you?

@Poussinou Poussinou mentioned this issue May 22, 2018
@moko256
Copy link
Owner

moko256 commented May 22, 2018

Thank you very much!

Tomorrow, I am going to do these.

  • Replace prebuilt jar with source code
  • Add Twitter API key not being public
  • Add tags
  • Fix insecure gradlew

@IzzySoft
Copy link

It would further help the issue if you could add tagged releases. Make the tag correspond to versionName (e.g. a version 1.2.3 should be tagged v1.2.3), so F-Droid always knows when a new release is available and can build automatically. If you also attach an .apk to such a release, I could pick that up to my repo (also automatically) until F-Droid gets started with it.

Thanks a lot!

@moko256
Copy link
Owner

moko256 commented May 22, 2018

I see. Thank you!

@moko256
Copy link
Owner

moko256 commented May 22, 2018

I'm sorry. I am not able to do it now.
Because it's still night here and I have to sleep.
Please wait until tomorrow.

@IzzySoft
Copy link

Take your time, @moko256 – nobody expects you to "jump on command". We're glad you're supporting us, and we definitely can wait another day (or a few, if needed) 😉

@IzzySoft
Copy link

@moko256 one of the maintainers asks:

Looks like this app requires API keys (see the README):

Add gradle.properties file and add CONSUMER_KEY and CONSUMER_SECRET properties for Twitter.

Does it work without those "secrets"?

If F-Droid builds your app, it must have all ingredients needed available. AFAIK we can't build apps where API keys etc. would be needed.

Maybe you can clarify here?

@moko256
Copy link
Owner

moko256 commented May 23, 2018

In a few days, I am going to upload Twitter API key encoded base64 and decoding code in this repository. So it works without secrets.

@IzzySoft
Copy link

You are aware that base64 encoding is no encryption, and thus that's the same like uploading the API key "plain text"? I'm not a dev, but this feels strange to me. I could be wrong of course…

@moko256
Copy link
Owner

moko256 commented May 23, 2018

It's same.
But that will make it a little difficult for simple BOT to steal API key.
But some people may steal it...

@IzzySoft
Copy link

IzzySoft commented May 23, 2018

@moko256 I've asked one of the F-Droid maintainers to come over here so you can discuss directly what steps are required or how to approach it. I simply lack the development background. I hope he checks with you soon.

That said, if you could meanwhile start with tagging the last release and attaching the corresponding .apk, I could already include your app with my repo (see above) until the other things are solved.

EDIT: relan just answered on the RFP issue:

Base64 is just a way to represent data, I see no problem here.

So if you see no problem either, it seems fine.

@moko256
Copy link
Owner

moko256 commented May 26, 2018

I fixed known problem.

@IzzySoft
Copy link

Thanks, @moko256 – I've asked our maintainers to "try a build".

@IzzySoft
Copy link

There still seem to be some issues. Quoting a maintainer:

gradle assembleRelease failed for me with

Could not determine the dependencies of task ':app:lintVitalRelease'.
> Could not resolve all task dependencies for configuration ':app:releaseRuntimeClasspath'.
   > Could not resolve project :japng-android:android_api.
     Required by:
         project :app
      > Unable to find a matching configuration of project :japng-android:android_api: None of the consumable configurations have attributes.
   > Could not resolve project :mastodon4j.
     Required by:
         project :app > project :mastodon4j_to_twitter4j
      > Unable to find a matching configuration of project :mastodon4j: None of the consumable configurations have attributes.
   > Could not resolve project :mastodon4j:mastodon4j.
     Required by:
         project :app > project :mastodon4j_to_twitter4j
      > Unable to find a matching configuration of project :mastodon4j:mastodon4j: None of the consumable configurations have attributes.

Also there is some junk in the repo that I had to remove manually (beause binaries):

  • twitter4j/..git
  • twitter4j/twitter4j-core/build
  • twitter4j/twitter4j-http2-support/build

Can you take a look and (hopefully) fix this?

@moko256
Copy link
Owner

moko256 commented May 27, 2018

I understood it.

@IzzySoft
Copy link

Thanks for saving me another crosspost 🤣 Direct conversation is better. Hope we get the bird flying soon 😉

@moko256
Copy link
Owner

moko256 commented May 27, 2018

The maintainer said it will be available on F-Droid in a few days in this .
Thank you!

1 similar comment
@moko256
Copy link
Owner

moko256 commented May 27, 2018

The maintainer said it will be available on F-Droid in a few days in this .
Thank you!

@moko256 moko256 closed this as completed May 27, 2018
@IzzySoft
Copy link

Why, thank YOU for supporting this 👍 🎉

Can't wait to give Twilatte a try 😇

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants