-
Notifications
You must be signed in to change notification settings - Fork 0
An in-range update of should is breaking the build 🚨 #3
Comments
Version 12.0.0 just got published.Your tests are still failing with this version. Compare the changes 🚨 Release NotesBetter Map Set equalityMap/Set/WeakMap/WeakSet equality checksUser @BridgeAR pointed to a number of bugs and inconcistency in Map/Set/WeakMap/WeakSet checks. To fix all this things, i switched map and set equality checks to do key checks defined in standard instead of value checks. const m1 = new Map([[{ a: 1 }, 11]]); const m2 = new Map([[{ a: 1 }, 11]]); And not this example is breaking. At first view it is a bit unclear why it should not be so. Consider another example: const m1 = new Map([[{}, 11], [{}, 12]]); const m2 = new Map([[{}, 11], [{}, 12]]); This example is not that clear if it should assert or not, right? (it should). As Map and Set (as their weak equavalents) allows to use any type value/ref as key, perfectly equal by value (what should.js do) {} and {} is not equal by reference. In should.js i am always trying to limit users to do not shoot themselfs in their foots and just do right thing if possible and when possible. That is why both examples will throw assertions starting 12.0.0. Consistency in bundlesFor the long time (probably several years now) browser bundle and node bundle has little differences in globals.
CommitsThe new version differs by 12 commits.
See the full diff |
Version 13.0.0 just got published.Your tests are still failing with this version. Compare the changes 🚨 CommitsThe new version differs by 11 commits.
See the full diff |
Version 13.0.1 just got published.Your tests are still failing with this version. Compare the changes 🚨 Release Notes13.0.1Add back missing umd build in root of package |
Version 13.1.0 just got published.Your tests are still failing with this version. Compare the changes 🚨 Release Notes13.1.0New
Fixes
import should from 'should'; CommitsThe new version differs by 6 commits.
See the full diff |
Version 13.1.1 just got published.Your tests are still failing with this version. Compare the changes 🚨 |
Version 13.1.2 just got published.Your tests are still failing with this version. Compare the changes 🚨 |
Version 13.1.3 just got published.Your tests are still failing with this version. Compare the changes 🚨 Release Notes13.1.3Fix #157 |
Version 13.2.0 just got published.Your tests are still failing with this version. Compare the changes 🚨 |
Version 13.2.1 just got published.Your tests are still failing with this version. Compare the changes 🚨 |
Version 13.2.2 just got published.Your tests are still failing with this version. Compare the changes 🚨 CommitsThe new version differs by 9 commits.
See the full diff |
Version 13.2.3 just got published.Your tests are still failing with this version. Compare the changes 🚨 |
Version 11.2.1 of should just got published.
This version is covered by your current version range and after updating it in your project the build failed.
As should is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.
I recommend you give this issue a high priority. I’m sure you can resolve this 💪
Status Details
Commits
The new version differs by 1 commits .
52b984f
Fix .match(RegExp) for everything not supported
See the full diff.
Not sure how things should work exactly?
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 🌴
The text was updated successfully, but these errors were encountered: