Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is NATS supported currently? #53

Closed
dehypnosis opened this issue Apr 30, 2019 · 7 comments
Closed

is NATS supported currently? #53

dehypnosis opened this issue Apr 30, 2019 · 7 comments

Comments

@dehypnosis
Copy link

var serviceBrokerConfig = &moleculer.Config{
	LogLevel: "info",
	Transporter: "nats://dev.nats.svc:4222",
}

Above configuration is ignored and just created MEMORY transporter, should i wait for the feature?

@slaterx
Copy link
Member

slaterx commented Apr 30, 2019

I think so.

Keep an eye on the documentation, we're working to keep that up-to-date as well:

https://moleculer-go-site.herokuapp.com/docs/0.1/broker.html

@dehypnosis
Copy link
Author

THANKS!

@slaterx
Copy link
Member

slaterx commented Apr 30, 2019

Feel free to ask us questions on our Glitter community: https://gitter.im/moleculer-go/community

@pentateu
Copy link
Member

@dehypnosis NATS streaming is the first transporter implemented, but it is not reading the URL from the config yet :( .. a very small thing to fix.. I'll get it done today, is in my list for some time.

@pentateu pentateu reopened this Apr 30, 2019
@dehypnosis
Copy link
Author

dehypnosis commented May 1, 2019

Currently, my team made a bunch of moleculer services based on moleculer-js with NATS transporter. And beyond node.js, we needed moleculer library based on fast compiled language like golang.

So after your release, I gladly made a PoC service with moleculer-go to try to connect existing services based on moleculer-js. For this yesterday I made a NATS transporter (not STAN) and a simple moleculer-go service. So messaging itself between moleculer-go and moleculer-js works well.

But current moleculer-go seems that has not exactly same protocol with moelculer-js. For example, moelculer-go discovers remote actions as []interfaces{} type assertion, but moleculer-js services reply as map[string]interfaces{}. And there some miscellaneous issues make runtime error while discovering, and call each others between different moleculer client library.

Anyway i'm on this issue, and almost modified code to discover and call each other well. But while i was working on it, I thought that it is not sure that does moleculer-go want to integrated with 'moelculer-js'.

So, here is a question, the differences between moleculer-go and moleculer-js about service discovery payload and actions catalog structure are intended design by moleculer-go author?

@pentateu
Copy link
Member

pentateu commented May 1, 2019

@dehypnosis this is awesome! One of the use cases that we believe people have and that this tool can be useful.

The goal is to be 100% compatible with Moleculer JS.

The reason you found this bug :( .. is because I have not done much testing integrating both (go and JS) yet, but this is in our roadmap. Looks like you started on it :) I'm happy to help u to get this over and quick.

Can you please share your NATS transporter?

Do you have a test with your transporter that I can use to see these error and do the fixes? I'm also happy to review and contribute to your PR to get this fixed.

@pentateu
Copy link
Member

pentateu commented May 1, 2019

@dehypnosis and @slaterx I create a new issue to fix the hardcoded problem -> #54

And this one related to Moleculer JS incompatibility. -> #55

I'm closing this one now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants