Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promise based makeExecutableSchema service method #88

Open
valeeum opened this issue Feb 16, 2021 · 0 comments
Open

Promise based makeExecutableSchema service method #88

valeeum opened this issue Feb 16, 2021 · 0 comments

Comments

@valeeum
Copy link

valeeum commented Feb 16, 2021

The ability to override makeExecutableSchema in the service is a great feature that opens up possibilities of doing interesting stuff like schema stitching, merging, etc. However, it would be much more useful if it allowed the response to be promise based.

			/**
			 * Call the `makeExecutableSchema`. If you would like
			 * to manipulate the concatenated typeDefs, or the generated schema,
			 * just overwrite it in your service file.
			 * @param {Object} schemaDef
			 */
			makeExecutableSchema(schemaDef) {
				return makeExecutableSchema(schemaDef);
			},
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant