started() and stopped()

[AndreMaz]

I think I found a solution to the started() and stopped() methods:

moleculer-template-project-typescript/template/services/greeter.service.ts

Lines 72 to 81 in ba8d5b8

	// started() {
	// },
	/**
	* Service stopped lifecycle event handler
	*/
	// stopped() {
	// },

That currently shows the following problem:
Type '() => void' is not assignable to type '() => Bluebird<void>'. Type 'void' is not assignable to type 'Bluebird<void>'.

The problem is in Moleculer's index.d.ts that requires returning a Bluebird promise

started?: () => Bluebird<void>;
stopped?: () => Bluebird<void>;

Because of this the only way to declare the started and stopped is

started() {
   return this.Promise.resolve() // this.Promise is a reference to Bluebird promise
}

However, it should be possible to use native promises and async/await. To make it work
index.d.ts must be updated as follows:

started?: () => PromiseLike<void>;
stopped?: () => PromiseLike<void>;

With PromiseLike the compiler will accept anything that looks like a promise.

@faeron @icebob I think this change won't break anything but I'm not sure because I'm a complete newbie in Typescript

[faeron]

Nice find ! 👏👏 I didn't find that solution when porting the template, thats why they are commented out :D
I also think that a change to the definition would not break anything.

[icebob]

I'm not a typescript guy, so I can't consider it, but please make a PR in moleculer repo and we will ask somebody to review it.

[AndreMaz]

Solved in #422