Improve AMQP Integration Tests

[Nathan-Schwartz]

Changes

• Remove legacy amqp tests
• Add important test cases for RPC
• Enhance purge function to allow clearing queues without deleting. Clears queues between tests and deletes queues and exchanges before and after suites.
• Fix type error in AMQP Transporter
• Run the same test suite for built-in and AMQP balancing
• preferLocal = false for RPC suite
• Run AMQP integration tests serially to prevent unexpected states

@icebob let me know if you any questions or concerns 👍

[coveralls]

Coverage remained the same at 98.543% when pulling 2a1886f on Nathan-Schwartz:amqp-integration-tests into 963e30a on ice-services:master.

[icebob]

Thanks Nathan, I'm checking....

[coveralls]

Coverage remained the same at 98.543% when pulling 327bcf3 on Nathan-Schwartz:amqp-integration-tests into 963e30a on ice-services:master.

[Nathan-Schwartz]

Just made a quick change so purge.js makes new channels instead of new connections.

[icebob]

@Nathan-Schwartz so, the rpc test is good, and I need to fix AMQP transporter to test will be passed?

[Nathan-Schwartz]

@icebob Yes, I think so.

I would expect these to fail, currently:

But sometimes the load balancing one fails, because ack happens before the action handler completes.

[icebob]

The last 2 test cases don't work with built-in balancer, only with disabled balancer

[Nathan-Schwartz]

@icebob Can you clarify?

Are you saying that you don't want them to work with built-in balancer, or that it doesn't currently?

[icebob]

It can't work, because Moleculer balancer put the request to the (i.e.) MOL.REQ.worker-1 queue. If no ack, RabbitMQ won't move this request to the MOL.REQ.worker-2 queue.

[icebob]

And also availability balancing is working only disabled balancer.
Broker put the request to *.worker-1, *.worker-2, *.worker-3.
But if you disable balancer, broker will put the request to MOL.REQB.test.hello queue.

[Nathan-Schwartz]

@icebob Ahh, okay. I didn't realize that. Thanks!

I will update the PR.

[icebob]

No, I fixed it :)

[icebob]

So, your first AMQP implementation was a disabled balancer solution, just I added the built-in balancer solution too.

[Nathan-Schwartz]

@icebob That looks really good!

I think maybe you switched true and false in the describe blocks 🙂

[icebob]

Yes, fixed :)
Btw, the test doesn't exit gracefully, maybe missing broker.stop?!?!

[brad-decker]

The collaboration on this is amazing. Thanks @Nathan-Schwartz and @icebob !

[icebob]

Ohh, the --runInBand blocking the exit.

[coveralls]

Coverage decreased (-0.3%) to 98.276% when pulling 49507ea on Nathan-Schwartz:amqp-integration-tests into 963e30a on ice-services:master.

[icebob]

@Nathan-Schwartz Do you know how we can use RabbitMQ on Travis CI?

[Nathan-Schwartz]

@icebob Ohh interesting. Nice find with forceExit 👍

I haven't set up RabbitMQ with Travis before, but it looks it shouldn't be too hard to configure:
https://docs.travis-ci.com/user/database-setup/#RabbitMQ

[icebob]

Great! I'm trying...

[coveralls]

Coverage decreased (-0.3%) to 98.276% when pulling 46b148e on Nathan-Schwartz:amqp-integration-tests into 963e30a on ice-services:master.

[coveralls]

Coverage decreased (-0.3%) to 98.276% when pulling 511cd04 on Nathan-Schwartz:amqp-integration-tests into 963e30a on ice-services:master.

[Nathan-Schwartz]

🎉

[icebob]

Wow, It passed! 🎉 :)

[Nathan-Schwartz]

Thanks Icebob!

[icebob]

Thanks Nathan, good job!

[icebob]

Now I have to go, I'm at midnight :)
I'm going to release a new version tomorrow.

[icebob]

I released a new version with this fix.
https://github.com/ice-services/moleculer/releases/tag/v0.11.3