Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moleculer-runner - fail fast, or provide liveness check #367

Closed
cameronbraid opened this issue Aug 20, 2018 · 1 comment
Closed

moleculer-runner - fail fast, or provide liveness check #367

cameronbraid opened this issue Aug 20, 2018 · 1 comment
Labels
Status: Need reproduce Issue waits for reproducing

Comments

@cameronbraid
Copy link

At the moment when a service fails to load the runner prints out an error message.

Therefore I need to monitor the logs detect that this has happened.

I would like moleculer-runner to either :

  • fail fast calling process.exit(1)
  • or provide a http liveness/health HTTP endpoint

This way the I can detect if a service fails.

For example when deploying moleculer services using kubernetes, the scheduler would detect crashing pods if process.exit was called, or I could setup a liveness check to monitor via HTTP

@icebob
Copy link
Member

icebob commented Sep 26, 2018

I think it's covered here: https://github.com/moleculerjs/moleculer/blob/master/bin/moleculer-runner.js#L442
Do you have a use-case when the runner doesn't exit when error happen?

@icebob icebob added the Status: Need reproduce Issue waits for reproducing label Sep 26, 2018
@icebob icebob closed this as completed Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Need reproduce Issue waits for reproducing
Projects
None yet
Development

No branches or pull requests

2 participants