URI with Query Params fails to match

[joe-finreach]

We recently upgraded to 2.7.2, and the pagination for our routes broke. When we tested what had changed, we discovered that when we added a query param to any route, the route was not matched. For example, if we had a route people/admin that rendered an Admin panel with a list of people, when we navigated to page two people/admin?page=2 the default route (404) showed. Downgrading wouter to 2.7.1 solved the problem for us.

[molefrog]

Hi @joe-finreach! Thanks for reporting.

Could you share a piece of code that broke in your app?

[joe-finreach]

Hi @molefrog I'm happy to share some code. Below is a snippet of (something like) the basic routing we had setup. This code works fine in 2.7.1, but renders the ErrorPage when accessing a URI like http://www.oursite.com/people?page=2 in 2.7.2

      <Switch>
        <Route path="/people" component={People} />
        <Route path="/courses" component={Courses} />
        <Route path="/goals" component={Goals} />
        <Route>
          <ErrorPage code="404" message="Page Not Found" />
        </Route>
      </Switch>

[molefrog]

Thanks, I think I've spotted the source of the problem already. It's this line:

wouter/use-location.js

Line 22 in 71ab672

prevPath.current !== pathname && update((prevPath.current = pathname));

I guess it should be instead:

prevPath.current !== pathname && prevPath.current = pathname && update(currentPathname(base)); 

Was recently changed in #169

[molefrog]

@joe-finreach Fixed in https://github.com/molefrog/wouter/releases/tag/v2.7.3