Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing type declaration for the new Router prop parent #270

Closed
waful opened this issue Nov 18, 2022 · 4 comments · Fixed by #274
Closed

Missing type declaration for the new Router prop parent #270

waful opened this issue Nov 18, 2022 · 4 comments · Fixed by #274

Comments

@waful
Copy link

waful commented Nov 18, 2022

https://github.com/molefrog/wouter/blob/main/types/ts4.1/index.d.ts#L125

I'm getting a ts error saying that parent doesn't exist on the Router type, which makes sense because it isn't declared in RouterProps. Unfortunately I am too new to typescript to be confident in contributing a fix.
@HansBrende
Copy link
Contributor

Ah yes, looks like updating types was missed in #265.

@molefrog FYI ^^^

@molefrog
Copy link
Owner

molefrog commented Dec 9, 2022

Ah, that's right. On it.

@molefrog molefrog mentioned this issue Dec 9, 2022
Merged
@molefrog
Copy link
Owner

molefrog commented Dec 9, 2022

Please see #274

@molefrog
Copy link
Owner

molefrog commented Jan 5, 2023

Released in v2.9.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix missing parent Router declarations molefrog/wouter
3 participants
@molefrog @waful @HansBrende