Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useCallback for setLocation #69

Closed
neves opened this issue Aug 9, 2019 · 2 comments · Fixed by #74
Closed

useCallback for setLocation #69

neves opened this issue Aug 9, 2019 · 2 comments · Fixed by #74

Comments

@neves
Copy link

neves commented Aug 9, 2019

Instead of anonymous function, returns a useCallback https://github.com/molefrog/wouter/blob/master/use-location.js#L16

const [, setLocation] = useLocation() setLocation should be the same on each render

@ifokeev
Copy link

ifokeev commented Aug 10, 2019

same issue here

@molefrog
Copy link
Owner

@neves @ifokeev That's a good point indeed. Thanks for bringing that up!
Going to let you guys know when the fix is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants