Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving towards removing "requirements" files. #1308

Open
molpopgen opened this issue Apr 19, 2024 · 0 comments
Open

Moving towards removing "requirements" files. #1308

molpopgen opened this issue Apr 19, 2024 · 0 comments

Comments

@molpopgen
Copy link
Owner

Currently, we specify dependencies in more than one place:

  1. pyproject.toml
  2. file in in requirements/

This redundancy leads to the obvious problems.
We can solve the problem by:

  1. Using optional features in pyproject.toml:
[project.optional-dependencies]
moments-popgen = ["moments-popgen>=1.2.0"]

These optional features can be for various tasks (development, CI, etc.)

  1. We than then do editable local installs for CI that tell cmake to do the right thing:

python -m pip install -Ccmake.define.BUILD_PYTHON_UNIT_TESTS=On -Ccmake.define.BUILD_CPP_UNIT_TESTS=On -e .

(Currently, the above doesn't work.
The C++ test suite ends up in the cmake build directory.
But we could output it somewhere sensible instead?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant