Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python constructor for mutation takes incorrect integer type #1023

Closed
molpopgen opened this issue Nov 7, 2022 · 0 comments
Closed

Python constructor for mutation takes incorrect integer type #1023

molpopgen opened this issue Nov 7, 2022 · 0 comments
Labels
bug C++ back end

Comments

@molpopgen
Copy link
Owner

The constructor takes unsigned for mutation origin times
but the correct type is signed.
Implicit casts have been at work here.
molpopgen added a commit that referenced this issue Nov 7, 2022
@molpopgen
Fix Python constructor for Mutation.
237e394 
* correct the integer type for origin times.
* Fixes #1023
@molpopgen molpopgen mentioned this issue Nov 7, 2022
Merged
molpopgen added a commit that referenced this issue Nov 7, 2022
@molpopgen
Fix pybind11 constructors for Mutation
a904fa3 
* Fixes #1023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug C++ back end
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@molpopgen