Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @gapstack/light-type #1032

Open
moltar opened this issue Feb 23, 2023 · 4 comments
Open

Add @gapstack/light-type #1032

moltar opened this issue Feb 23, 2023 · 4 comments
Labels
new package Adds a new validation package.

Comments

@moltar
Copy link
Owner

moltar commented Feb 23, 2023

https://github.com/Nick-Lucas/gapstack/blob/main/packages/light-type/README.md

Mentioned here: https://dev.to/nicklucas/typescript-runtime-validators-and-dx-a-type-checking-performance-analysis-of-zodsuperstructyuptypebox-5416

Ping @Nick-Lucas

@moltar moltar added the new package Adds a new validation package. label Feb 23, 2023
@Nick-Lucas Nick-Lucas mentioned this issue Feb 25, 2023
@Nick-Lucas
Copy link

Hey @moltar, added this out of interest last night so I've opened a PR.

The tests are just a copy & paste of zod's test, since drop-in compat is a core goal of the project

It's fascinating how the type-checkers which require extra plugins/transpilation blow everyone else away though.

@Nick-Lucas
Copy link

One frustrating thing, is I added strict/passthrough support and updated the library, but even after blowing out node_modules ts-node seems to be caching the old version from somewhere, so I can't actually run the benchmarks locally anymore. Have you come across this?

@moltar
Copy link
Owner Author

moltar commented Feb 25, 2023

Have you come across this?

Hm, no, sorry. 🤔

I think CI environment should be pristine, so it will run fine there. I just approved the run.

@Nick-Lucas
Copy link

Nick-Lucas commented Feb 25, 2023

Very weird, it's failing to check the .d.ts files from light-type in CI. Since a lot of libs are not having issues there I assume it's a legit problem, so I'll need to have a look at the build 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new package Adds a new validation package.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants