This repository has been archived by the owner on Apr 27, 2023. It is now read-only.
feat: configure page paths via options #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://gatsby-theme-moltin-git-feat-custom-catalog-paths.moltin.now.sh |
notrab
commented
Jul 11, 2019
|
|
||
| return { | ||
| plugins: [ | ||
| { | ||
| resolve: `@moltin/gatsby-source-moltin`, | ||
| options: { client_id } | ||
| options: { client_id: client_id || clientId }, |
There was a problem hiding this comment.
So, we should support both and phase out client_id.
There was a problem hiding this comment.
@notrab This should be reflected at gatsby-source-moltin too.
There was a problem hiding this comment.
@ynnoj Yep! Done, will submit another PR later.
ynnoj
approved these changes
Jul 12, 2019
|
|
||
| return { | ||
| plugins: [ | ||
| { | ||
| resolve: `@moltin/gatsby-source-moltin`, | ||
| options: { client_id } | ||
| options: { client_id: client_id || clientId }, |
There was a problem hiding this comment.
@notrab This should be reflected at gatsby-source-moltin too.
notrab
added a commit
that referenced
this pull request
Jul 12, 2019
* feat: configure page paths via options * docs: update README
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
notrab
added a commit
that referenced
this pull request
Jul 12, 2019
* feat: configure page paths via options * docs: update README
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds config to change the path to the catalog pages.