made file dimensions and weight/height optionals. #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se from finding API responses with blank diminesions. Still do not know why but do not see any downside in optionals here.
|
@gje4 Could we remove the version string changes from this PR? Also looks like there's some conflicts now to resolve with the master branch. |
craigtweedy
approved these changes
Dec 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@craigtweedy when you have a second. This is per our conversation yesterday about files.
Status
Type
Fixes a bug
Description
FileDimensions can be blank for some reason.
Notes
https://moltin.atlassian.net/browse/CA-535 , open question about how dimensions can be blank.