Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Z-space diagnostics should use the ALE remapping #62

Closed
adcroft opened this issue Sep 25, 2014 · 2 comments
Closed

Z-space diagnostics should use the ALE remapping #62

adcroft opened this issue Sep 25, 2014 · 2 comments
Assignees
@adcroft
Labels
enhancement
Milestone
CMOR-ization of d...

Comments

@adcroft
Copy link
Collaborator

adcroft commented Sep 25, 2014

The z-space diagnostics are currently using a simple interpolation in the vertical for scalars.

To do:

  • Invoke the remapping routines used for ALE to access high-order conservative remapping.
  • Transports are already conservatively remapped but could also be made higher-order.
@adcroft adcroft self-assigned this Sep 25, 2014
@adcroft adcroft added this to the CMOR-ization of diagnostics milestone Sep 25, 2014
@adcroft
Copy link
Collaborator Author

adcroft commented Apr 14, 2015

  • Once we are using the remapping toolbox we can and should generalize this code to remap to other spaces (e.g. density).
  • We also need find a way to pass through CMOR optional information to z- or rho-space output.

@nichannah nichannah mentioned this issue Apr 24, 2015
Closed
@nichannah nichannah mentioned this issue May 5, 2015
Closed
nichannah added a commit to nichannah/MOM6 that referenced this issue Jun 3, 2015
@nichannah
Split Zstar grid creation up so can be done column-by-column. mom-oce…
a4a2ed8 
…an#62
nichannah added a commit to nichannah/MOM6 that referenced this issue Jun 3, 2015
@nichannah
Fix output from remapping conservation check. mom-ocean#62
f3dbcb4
nichannah added a commit to nichannah/MOM6 that referenced this issue Jun 3, 2015
@nichannah
Only initialise diag_mediator after h and G have been set up. mom-oce…
194cea5 
…an#62
nichannah added a commit to nichannah/MOM6 that referenced this issue Jun 3, 2015
@nichannah
Disable old Z space diagnostic remapping for tracers. Will eventually…
4fb1324 
… be removed. mom-ocean#62
nichannah added a commit to nichannah/MOM6 that referenced this issue Jun 3, 2015
@nichannah
Create diag variation that remaps T+layer diagnostics automatically. m…
5facb96 
…om-ocean#62
nichannah added a commit to nichannah/MOM6 that referenced this issue Jun 3, 2015
@nichannah
Reduce the minimum regridding thickness. Necessary for conservation when
e9cf620 
there are many thin layers. mom-ocean#62
nichannah added a commit to nichannah/MOM6 that referenced this issue Jun 4, 2015
@nichannah
Split Zstar grid creation up so can be done column-by-column. mom-oce…
0dda96c 
…an#62
nichannah added a commit to nichannah/MOM6 that referenced this issue Jun 4, 2015
@nichannah
Fix output from remapping conservation check. mom-ocean#62
6911097
nichannah added a commit to nichannah/MOM6 that referenced this issue Jun 4, 2015
@nichannah
Only initialise diag_mediator after h and G have been set up. mom-oce…
b10da82 
…an#62
nichannah added a commit to nichannah/MOM6 that referenced this issue Jun 4, 2015
@nichannah
Disable old Z space diagnostic remapping for tracers. Will eventually…
51c9ec6 
… be removed. mom-ocean#62
nichannah added a commit to nichannah/MOM6 that referenced this issue Jun 4, 2015
@nichannah
Create diag variation that remaps T+layer diagnostics automatically. m…
f320f0a 
…om-ocean#62
nichannah added a commit to nichannah/MOM6 that referenced this issue Jun 4, 2015
@nichannah
Reduce the minimum regridding thickness. Necessary for conservation when
d38f434 
there are many thin layers. mom-ocean#62
nichannah added a commit to nichannah/MOM6 that referenced this issue Jun 4, 2015
@nichannah
Set the minimum layer thickness for remapping only. mom-ocean#62
a3c1d00
nichannah added a commit to nichannah/MOM6 that referenced this issue Jun 4, 2015
@nichannah
Set the minimum layer thickness for remapping only. mom-ocean#62
9ecfe58
nichannah added a commit to nichannah/MOM6 that referenced this issue Jun 5, 2015
@nichannah
Don't move call to diag_mediator_init, setup pointer to H with setter…
9ab9b68 
… method. mom-ocean#62
nichannah added a commit to nichannah/MOM6 that referenced this issue Jun 5, 2015
@nichannah
Remove unnecessary addition of optional arguments. mom-ocean#62
423b0ee
nichannah added a commit to nichannah/MOM6 that referenced this issue Jun 5, 2015
@nichannah
Change name of ALE remapped Z level diagnostics to have _z_new suffix…
d4e25ec 
…, avoids conflict with existing Z level diagnostics. mom-ocean#62
nichannah added a commit to nichannah/MOM6 that referenced this issue Jun 5, 2015
@nichannah
Remove unnecessary include. mom-ocean#62
70e5686
nichannah added a commit to nichannah/MOM6 that referenced this issue Jun 5, 2015
@nichannah
Improve specification of grid definition file,variable used for
14aa761 
diagnostic remapping. Also use library to read netCDF files. mom-ocean#62
nichannah added a commit to nichannah/MOM6 that referenced this issue Jun 5, 2015
@nichannah
Improve specification of grid definition file,variable used for
d556620 
diagnostic remapping. The format is now:
        DIAG_REMAP_Z_GRID_DEF = "FILE:OM3_zgrid.nc,zw"

Also use library to read netCDF files. mom-ocean#62
nichannah added a commit to nichannah/MOM6 that referenced this issue Jun 9, 2015
@nichannah
Support remapping of variables on u, v grids. mom-ocean#62
942d5c8
nichannah added a commit to nichannah/MOM6 that referenced this issue Jun 10, 2015
@nichannah
Move diag remapping into per-column subroutine, easier to remap u, v …
75030da 
…grids. mom-ocean#62
nichannah added a commit to nichannah/MOM6 that referenced this issue Jun 10, 2015
@nichannah
Set 3d mask and axes separately. mom-ocean#62
379dc61
nichannah added a commit to nichannah/MOM6 that referenced this issue Jun 10, 2015
@nichannah
Check relative and absolute errors when doing conservative remapping. m…
df828f0 
…om-ocean#62
nichannah added a commit to nichannah/MOM6 that referenced this issue Jul 15, 2015
@nichannah
Set 3d mask and axes separately. mom-ocean#62
d9297bd
nichannah added a commit to nichannah/MOM6 that referenced this issue Jul 15, 2015
@nichannah
Check relative and absolute errors when doing conservative remapping. m…
d39cf62 
…om-ocean#62
nichannah added a commit to nichannah/MOM6 that referenced this issue Jul 15, 2015
@nichannah
Estimate h and depth for u, v, B grids when doing diag remapping. mom…
759adfd 
…-ocean#62
nichannah added a commit to nichannah/MOM6 that referenced this issue Jul 15, 2015
@nichannah
Don't support remapping of diagnostics on B axes. mom-ocean#62
dfc52bc
nichannah added a commit to nichannah/MOM6 that referenced this issue Jul 15, 2015
@nichannah
Remove unused code, improve assert() messages. mom-ocean#62
3554d6e
nichannah added a commit to nichannah/MOM6 that referenced this issue Jul 15, 2015
@nichannah
Code formatting fixes. mom-ocean#62
5d03e9d
nichannah added a commit to nichannah/MOM6 that referenced this issue Jul 15, 2015
@nichannah
Get h averaging right on u, v grids. mom-ocean#62
ede11b7
nichannah added a commit to nichannah/MOM6 that referenced this issue Jul 15, 2015
@nichannah
Update diag_mediator public interface. mom-ocean#62
8bc1092
nichannah added a commit to nichannah/MOM6 that referenced this issue Jul 16, 2015
@nichannah
Put diag Z grid updates all over the place. mom-ocean#62
218f75e
nichannah added a commit to nichannah/MOM6 that referenced this issue Jul 16, 2015
@nichannah
Restructuring of z star remapping to build grids less frequently. mom…
d712465 
…-ocean#62
nichannah added a commit to nichannah/MOM6 that referenced this issue Jul 16, 2015
@nichannah
Get h averaging right on u, v grids. mom-ocean#62
ecccf84
nichannah added a commit to nichannah/MOM6 that referenced this issue Jul 16, 2015
@nichannah
Added calls to generate/update z-star grid for diagnostic remapping p…
7a990db 
…urposes.

This grid needs to updated everytime H changes. mom-ocean#62
nichannah added a commit to nichannah/MOM6 that referenced this issue Jul 16, 2015
@nichannah
Added calls to generate/update z-star grid for diagnostic remapping p…
4941877 
…urposes.

This grid needs to updated everytime H changes. mom-ocean#62
nichannah added a commit to nichannah/MOM6 that referenced this issue Jul 16, 2015
@nichannah
Code to check whether H has changed on diag post(). mom-ocean#62
49cd415
nichannah added a commit to nichannah/MOM6 that referenced this issue Jul 16, 2015
@nichannah
Change interface of diag_update_target_grid - no need to take H as an…
bc8a185 
… input. mom-ocean#62
nichannah added a commit to nichannah/MOM6 that referenced this issue Jul 17, 2015
@nichannah
Clean up comments and interface to diag grid definition update. mom-o…
b690e3b 
…cean#62
nichannah added a commit to nichannah/MOM6 that referenced this issue Jul 17, 2015
@nichannah
Diag mediator deallocates memory at end(). mom-ocean#62
d485907
nichannah added a commit to nichannah/MOM6 that referenced this issue Jul 22, 2015
@nichannah
Move calls to update grid for z remapping of diagnostics out of
8008eea 
continuity(). It is not necessary to pass the diag mediator structure
into calls to continuity(). mom-ocean#62
nichannah added a commit to nichannah/MOM6 that referenced this issue Jul 28, 2015
@nichannah
Fix dummy argument intent. Does not compile on Gaea. mom-ocean#62
604681e
nichannah added a commit to nichannah/MOM6 that referenced this issue Jul 28, 2015
@nichannah
Don't build diagnostic Z remapping grids if grid definition param not
d0e99df 
provided. mom-ocean#62
nikizadehgfdl pushed a commit to nikizadehgfdl/MOM6 that referenced this issue Oct 9, 2017
@nichannah
Remapped diagnostic TKE_to_Kd is broken, skip for now. mom-ocean#62
b25b8b9
nikizadehgfdl pushed a commit to nikizadehgfdl/MOM6 that referenced this issue Oct 9, 2017
@adcroft
Merge pull request mom-ocean#35 from nicjhan/62-remap-diag-tests
f93538a 
Remapped diagnostic TKE_to_Kd is broken, skip for now. mom-ocean#62
nikizadehgfdl pushed a commit to nikizadehgfdl/MOM6 that referenced this issue Oct 9, 2017
@adcroft
MOM6 Merge branch 'nicjhan-62-z-ALE-remapping' into dev/master
9956361 
- NOAA-GFDL/MOM6@d00d001 Merge branch 'nicjhan-62-z-ALE-remapping' into dev/master
- NOAA-GFDL/MOM6@d556620 Improve specification of grid definition file,variable used for diagnostic remapping. The format is now:         DIAG_REMAP_Z_GRID_DEF = "FILE:OM3_zgrid.nc,zw"
- NOAA-GFDL/MOM6@70e5686 Remove unnecessary include. mom-ocean#62
- NOAA-GFDL/MOM6@d4e25ec Change name of ALE remapped Z level diagnostics to have _z_new suffix, avoids conflict with existing Z level diagnostics. mom-ocean#62
- NOAA-GFDL/MOM6@423b0ee Remove unnecessary addition of optional arguments. mom-ocean#62
- NOAA-GFDL/MOM6@9ab9b68 Don't move call to diag_mediator_init, setup pointer to H with setter method. mom-ocean#62
- NOAA-GFDL/MOM6@9ecfe58 Set the minimum layer thickness for remapping only. mom-ocean#62
- NOAA-GFDL/MOM6@d38f434 Reduce the minimum regridding thickness. Necessary for conservation when there are many thin layers. mom-ocean#62
- NOAA-GFDL/MOM6@f320f0a Create diag variation that remaps T+layer diagnostics automatically. mom-ocean#62
- NOAA-GFDL/MOM6@51c9ec6 Disable old Z space diagnostic remapping for tracers. Will eventually be removed. mom-ocean#62
- NOAA-GFDL/MOM6@b10da82 Only initialise diag_mediator after h and G have been set up. mom-ocean#62
- NOAA-GFDL/MOM6@6911097 Fix output from remapping conservation check. mom-ocean#62
- NOAA-GFDL/MOM6@0dda96c Split Zstar grid creation up so can be done column-by-column. mom-ocean#62
nikizadehgfdl pushed a commit to nikizadehgfdl/MOM6 that referenced this issue Oct 9, 2017
@nichannah
Parameter documentation for new Z remapping option. mom-ocean#62
7fceaa5
nikizadehgfdl pushed a commit to nikizadehgfdl/MOM6 that referenced this issue Oct 9, 2017
@nichannah
Enable option for diag regridding to Z. mom-ocean#62
7c48f32
nikizadehgfdl pushed a commit to nikizadehgfdl/MOM6 that referenced this issue Oct 9, 2017
@adcroft
MOM6: Merged multiple pull requests 🎪
103c048 
- NOAA-GFDL/MOM6@6b4a320 Merge branch 'nicjhan-62-z-remapping-uv-grids' into dev/master
- NOAA-GFDL/MOM6@d0e99df Don't build diagnostic Z remapping grids if grid definition param not provided. mom-ocean#62
- NOAA-GFDL/MOM6@604681e Fix dummy argument intent. Does not compile on Gaea. mom-ocean#62
- NOAA-GFDL/MOM6@e35830a Merge branch 'angus-g-diag-eta-preale' into dev/master
- NOAA-GFDL/MOM6@e39aa4b Merge branch 'diag-eta-preale' of https://github.com/angus-g/MOM6 into angus-g-diag-eta-preale
- NOAA-GFDL/MOM6@b10de2d Merge branch 'nicjhan-189-H_to_m' into dev/master
- NOAA-GFDL/MOM6@6289604 Merge branch '189-H_to_m' of https://github.com/nicjhan/MOM6 into nicjhan-189-H_to_m
- NOAA-GFDL/MOM6@2e51382 Fixed G%gridLoaTn and G%girdLonB in "spherical" model
- NOAA-GFDL/MOM6@8008eea Move calls to update grid for z remapping of diagnostics out of continuity(). It is not necessary to pass the diag mediator structure into calls to continuity(). mom-ocean#62
- NOAA-GFDL/MOM6@0b08d8c Do m_to_H conversion within ALE regridding. ALE_main() now handles arbitrary H units - no need to convert to m before calling it. mom-ocean#189
- NOAA-GFDL/MOM6@5923919 Changes to meet review comments mom-ocean#189:   - show ranks when doing vector multiplies,   - replace G%Angstrom_z with G%Angstrom in various places,   - fix units of eta_bt,   - improve comments
- NOAA-GFDL/MOM6@d701204 Unit conversions to support H vertical unit independant of m. No results change. Closes mom-ocean#189
- NOAA-GFDL/MOM6@bf06b59 Remove unused variables. mom-ocean#189
- NOAA-GFDL/MOM6@19bed14 Add additional checksums, do H unit conversion on checksum arrays. mom-ocean#189
- NOAA-GFDL/MOM6@032a76d Comment and whitespace fixes. mom-ocean#189
- NOAA-GFDL/MOM6@f629970 Add e_preale diagnostic
- No answer changes.
nikizadehgfdl pushed a commit to nikizadehgfdl/MOM6 that referenced this issue Oct 9, 2017
@adcroft
Merge pull request mom-ocean#62 from NOAA-GFDL/nikizadehgfdl-patch-3
0f930f8 
Update EddyKineticEnergy.py

- area_t became areacello in ocean_static.nc
@Hallberg-NOAA
Copy link
Collaborator

There is a consensus that this issue was resolved several years ago.

MJHarrison-GFDL pushed a commit to MJHarrison-GFDL/MOM6 that referenced this issue Aug 16, 2022
@underwoo
affinity.c get_cpu_affinity only one return
ebf8e41 
The `get_cpu_affinity` function in `mpp/affinity.c` had two return lines
that essentially resulted in only one possible return value `first_cpu`.
This commite reduces the return statement to simply `return first_cpu`.

Resolves mom-ocean#62.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adcroft adcroft

Labels
enhancement
Projects
None yet
Milestone
CMOR-ization of diagnostics
Development

No branches or pull requests
2 participants
@adcroft @Hallberg-NOAA