Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize massless layers to 0 thickness so masked-PE results reproduce non-masked #73

Closed
adcroft opened this issue Oct 15, 2014 · 3 comments
Assignees

Comments

@adcroft
Copy link
Collaborator

adcroft commented Oct 15, 2014

To avoid divisions by zero, thicknesses default to ANGSTROM. ANGTROM=0 should work and doing so will allow us to test and validate solutions with and without mask_tables.

  • Might need to add land masks to the APE calculation.
@adcroft
Copy link
Collaborator Author

adcroft commented Nov 26, 2014

Commit 0f7c079 solves the issue of masked PEs changing the APE calculation.

Leaving ticket open since we still need to check that initializing massless layers to ANGSTROM with ANGSTROM=0 works (should do but hasn't been verified).

@adcroft
Copy link
Collaborator Author

adcroft commented Apr 2, 2015

This is just an update. I just tried ANGSTROM=0 with a mix of results:

core dump for MESO_025_63L, benchmark, flow_downslope/layer, global, global_ALE/layer, nonBous_global, resting

Answer changes for DOME, Phillips_2layer, double_gyre, flow_downslope/rho, flow_downslope/z, seamount/layer, seamoount/z, single_column, single_column_z

Fortunately, core dumps are easy to debug. I suspect we are using ANGSTROM where we should be using G%H_neglect, in a few places.

gustavo-marques added a commit to gustavo-marques/MOM6 that referenced this issue Aug 31, 2018
…ground

add latitudinally varying background diffusivity
@Hallberg-NOAA
Copy link
Collaborator

We have been able to use ANGSTROM=0 for all of the test cases in MOM6-examples for over a year now, although this does require that the various ..._2018_ANSWERS run-time flags be set to .false. (which has been the default since PR #1127 was merged into dev/gfdl in June, 2020). Both the change to ANGSTROM = 0 and changing the value of the various ..._2018_ANSWERS flags will change answers, although the solutions are all qualitatively similar.

MJHarrison-GFDL pushed a commit to MJHarrison-GFDL/MOM6 that referenced this issue Jun 15, 2021
- Closes mom-ocean#73
- Fix answer changes with changes in SIS2 layout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants