Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behavior change for guessed UTC in 0.5.15 #598

Closed
craigforster opened this issue Apr 17, 2018 · 2 comments
Closed

Behavior change for guessed UTC in 0.5.15 #598

craigforster opened this issue Apr 17, 2018 · 2 comments
Assignees
Labels

Comments

@craigforster
Copy link

The latest release has changed the behavior when UTC is configured on the server. Previously, UTC was reported as Etc/UTC and now it's reported as Etc/Universal. This breaks downstream dependencies that rely on on detecting Etc/UTC (for better or worse), for example https://github.com/gautamsi/ews-javascript-api.

Reproduction script:

guess.js:

const moment = require('moment-timezone');
console.log(moment.tz.guess());

With 0.5.14:

$ TZ=Etc/UTC node guess.js
Etc/UTC

With 0.5.15:

$ TZ=Etc/UTC node guess.js
Etc/Universal

This looks to be due to the change in the data files, the 2017c version contains "Etc/UTC|UTC|0|0|", whereas the 2018d version contains "Etc/Universal|UTC|0|0|",.

@ellenaua
Copy link
Contributor

@craigforster Thanks! I Just released 0.5.16 with a fix.

@craigforster
Copy link
Author

Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants