Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis CI build failing #624

Closed
aadityakulkarni opened this issue Jun 7, 2018 · 3 comments
Closed

Travis CI build failing #624

aadityakulkarni opened this issue Jun 7, 2018 · 3 comments

Comments

@aadityakulkarni
Copy link

aadityakulkarni commented Jun 7, 2018

It looks like Travis CI build is failing. I have seen a couple of pull requests where build failed for the same error as below:

`1.26s$ npm test

moment-timezone@0.5.17 test /home/travis/build/moment/moment-timezone
grunt
/home/travis/build/moment/moment-timezone/node_modules/grunt/node_modules/grunt-legacy-log/node_modules/grunt-legacy-log-utils/node_modules/chalk/index.js:2
const escapeStringRegexp = require('escape-string-regexp');
^^^^^
SyntaxError: Use of const in strict mode.`

Following is the link to my PR where the build failed:
Travis build

Can someone take a look and help me with this?

@ellenaua
Copy link
Contributor

@aadityakulkarni just use var there instead of const

@aadityakulkarni
Copy link
Author

Hi @ellenaua - Actually it's not me. It seems grunt uses npm package "chalk" which uses const instead of var and that is causing the build to fail.

/home/travis/build/moment/moment-timezone/node_modules/grunt/node_modules/grunt-legacy-log/node_modules/grunt-legacy-log-utils/node_modules/chalk/index.js:2 const escapeStringRegexp = require('escape-string-regexp'); ^^^^^ SyntaxError: Use of const in strict mode.

The following PR and its corresponding build also had the same issue:

PR: #622
Travis CI: https://travis-ci.org/moment/moment-timezone/builds/388735890?utm_source=github_status&utm_medium=notification

@gilmoreorless
Copy link
Member

Fixed in #1002

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants