Update lang/zh-cn.js #1076
Merged
Update lang/zh-cn.js #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 14, 2013 00:59
use "本周" for current week
|
Can you please rebase your changes on top of latest rebase. |
|
@ichernev OK, I'll update test script & rebase my changes later. |
| nextWeek : function () { | ||
| var startOfWeek, prefix; | ||
| startOfWeek = moment().startOf('week'); | ||
| prefix = this.unix() - startOfWeek.unix() >= 7 * 24 * 3600 ? '[下]' : '[本]'; |
There was a problem hiding this comment.
Why would the time from the start of the week to now be more than 7 days?
You can also use moment().startOfWeek().diff() -- that would give a negative number of milliseconds.
There was a problem hiding this comment.
Ah, I see what you're doing. Ignore my comment :)
|
Thank you for fixing those. Sorry for the delay, I was just hoping to get another opinion on that. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update lang/zh-cn.js, which is more corresponding to the Chinese expression.
更新 lang/zh-cn.js 使之更符合中文表达习惯