make iso parsing a bit stricter #1092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -29,8 +29,8 @@ exports.create = { | |||
| test.ok(moment({year: 2010, month: 1, day: 12}).toDate() instanceof Date, "{year: 2010, month: 1, day: 12}"); | |||
| test.ok(moment({year: 2010, month: 1, day: 12, hours: 1}).toDate() instanceof Date, "{year: 2010, month: 1, day: 12, hours: 1}"); | |||
| test.ok(moment({year: 2010, month: 1, day: 12, hours: 1, minutes: 1}).toDate() instanceof Date, "{year: 2010, month: 1, hours: 12, minutes: 1, seconds: 1}"); | |||
| test.ok(moment({year: 2010, month: 1, day: 12, hours: 1, minutes: 1, seconds: 1}).toDate() instanceof Date, "{year: 2010, month: 1, day: 12, hours: 1, minutes: 1, seconds: 1]"); | |||
There was a problem hiding this comment.
just fixing the comment slightly while I was here
|
Looks great! Thanks! |
ichernev
added a commit
that referenced
this pull request
Sep 16, 2013
make iso parsing a bit stricter
|
This breaks parsing valid ISO Formats. Take for instance a date from postgres timestamp with time zone. Parses as invalid date - 2013-12-10T21:56:00-05 which is a perfectly valid ISO Date - http://www.cl.cam.ac.uk/~mgk25/iso-time.html |
|
@jeverden thanks. The right solution is to fix the regex, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1083. To try fixing this without breaking anything, I experimented with trying
new Date(str)first and only trying the ISO regex if that didn't work, That had strange results, namely thatnew Date('1983-10-14')gets interpreted as UTC, so you end up with "Thu Oct 13 1983 20:00:00 GMT-0400 (EDT)".So I stuck with my original idea of forcing ISO strings to end the string. This will of course break code that has a valid ISO-8601 string followed by a bunch of unparsable stuff. I think that's acceptable, since you don't normally expect ISO-compliant strings to also contain gibberish.