More precise parsing with an array of formats #1094
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 1:
When moment parses string with a few formats, only last part of unparsed string has influence on format penalty. For example, for string '11-02-10', formats 'MM DD YY' and 'DD-MM-YY' have same penalty, and it's 0. But as you can see, they have different separators ' ' and '-', that should have influence on penalty.
Now moment can distinguish those separators, and our formats ('MM DD YY' and 'DD-MM-YY') will have penalty 2 and 0 respectively.
Commit 2:
In gettings regex for token, special RegExp chars, such as point, slash, etc, should be escaped to prevent positive matching with other separators. For example, for string '11-02-10', format 'MM.DD.YY' has 0 penalty, because RegExp('.') positive mathes with '-'.
Now moment escapes the chars and our format will have penalty 2.