repairing language tests #1177
Merged
repairing language tests #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That makes sense. Thanks! |
This was referenced Oct 14, 2013
|
This is due to a hack I wrote to simulate https://github.com/moment/momentjs.com/blob/gh-pages/source/js/test-start.js#L2-L4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added tests to verify that languages actually exported the language they contain, but the way the test is written, it only works correctly in Node, since AMD passes the result through a callback, not as the return value to require. So our tests were failing in the browser.
I just made the test not run in the browser, and then verified it using a local instance of momentjs.com.