-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meridiem Parser support for Korean #1362
Conversation
@@ -51,6 +54,10 @@ | |||
y : "일년", | |||
yy : "%d년" | |||
}, | |||
ordinal : '%d일' | |||
ordinal : '%d일', | |||
meridiemParse : /(오전|오후)/i, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take a look at the English version:
meridiem : function (hours, minutes, isLower) {
if (hours > 11) {
return isLower ? 'pm' : 'PM';
} else {
return isLower ? 'am' : 'AM';
}
},
I think you may want to do the same (becuase you used the i
flag in the RegExp).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no capped letter in Korean. I removed unnecessary "i" flag.
There is no capped letter in Korean.
Meridiem Parser support for Korean
Thank you! |
I found that almost of language datas can't support parse meridiem correctly now.
I made a fix and test case for Korean language data.
before this fix:
with this fix: