Handle wrongly cloned moments

[ichernev]

This is in response to #1404

• detect moment objects that were cloned with something like _.extend({}, moment()) as isMoment-s
• properly clone them and produce orthodox moment objects

Please interested parties (@chilversc, @mattbrooks2010, @RomanDidenko) -- test on knockout, or whatever fancy libraries you happen to use if it works fine with them.

[RomanDidenko]

I've tested changes on my functionality and had no issues anymore.

Thanks for the commit.

[mattbrooks2010]

I tested these changes using Knockout's ko.toJSON(...). The following works:

ko.toJSON(moment());

However, the following still results in the same RangeError as before:

ko.toJSON(moment.utc());

I've included the call stack in case it is any help.

RangeError: Maximum call stack size exceeded
    at moment (RangeError: Maximum call stack size exceeded
    at moment (moment.js:1576:9)
    at Object.extend.clone (moment.js:1756:20)
    at Object.extend.toString (moment.js:1768:25)
    at RegExp.exec (native)
    at makeDateFromInput (moment.js:1403:39)
    at makeMoment (moment.js:1565:13)
    at moment (moment.js:1576:16)
    at Object.extend.clone (moment.js:1756:20)
    at Object.extend.toString (moment.js:1768:25)
    at RegExp.exec (native) moment.js:1576:9)
    at Object.extend.clone (moment.js:1756:20)
    at Object.extend.toString (moment.js:1768:25)
    at RegExp.exec (native)
    at makeDateFromInput (moment.js:1403:39)
    at makeMoment (moment.js:1565:13)
    at moment (moment.js:1576:16)
    at Object.extend.clone (moment.js:1756:20)
    at Object.extend.toString (moment.js:1768:25)
    at RegExp.exec (native) 

[ichernev]

@mattbrooks2010 yeah. I missed moment.utc. Now it works, I tested with ko and added tests.

[mattbrooks2010]

Confirmed - thank you. Do you know when a release will be available via NuGet?

[icambron]

Looks great