Set AMD global before module definition #1590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icambron
added a commit
that referenced
this pull request
Apr 4, 2014
Set AMD global before module definition
|
Sigh. This kind of thing is everything I hate about JS. That they didn't build modules into the fucking language is infuriating. |
|
Yup, was very frustrating to debug. This change isn't strictly required since wrapShim handles it. You might want to change the wrapShim mention in the docs to say that it's only necessary in X versions since it won't be necessary if this PR is merged. |
|
The doc states the version exactly. Modules are also pretty hard to get right, you have to agree. The fact that there are multiple semi compatible options is revealing. Languages nowadays ship with package managers... 10 years ago - not so much. Es6 has them. So in 10 years we'll be all set :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure non AMD compatible modules work well with moment in require.js. This is based on #1574