perf(makeDateFromInput): no need to match regex if input is a Date #1708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The moment constructor when passed a Date should be the fastest. There is no need to match the aspNetJsonRegex before testing if the `input` is a Date.
| return; | ||
| } | ||
|
|
||
| var matched = aspNetJsonRegex.exec(input); |
There was a problem hiding this comment.
I don't know why jshint doesn't scream about that, but each function should have only one var at the top. Just declare it at the top and define it here. matched can also be set inside the if statement (its only used inside).
|
Makes sense. Thanks! |
icambron
added a commit
that referenced
this pull request
Jul 1, 2014
perf(makeDateFromInput): no need to match regex if input is a Date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The moment constructor when passed a Date should be the fastest. There is
no need to match the aspNetJsonRegex before testing if the
inputis aDate.