Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix up defineLocale for 3.0 #1796

Closed
icambron opened this issue Jul 24, 2014 · 2 comments
Closed

Fix up defineLocale for 3.0 #1796

icambron opened this issue Jul 24, 2014 · 2 comments
Labels
Breaking change Enhancement Up-For-Grabs
Milestone
3.0

Comments

@icambron
Copy link
Member

Continued from #1761, we want to clean up locale setting for 3.0:

  • Make defineLocale not set the global locale
  • Remove the hack around lazy-loaded locales in Node
  • Remove the hack to set the locale back to English in the embedLocales task
@icambron icambron added this to the 3.0 milestone Jul 24, 2014
@icambron icambron mentioned this issue Jul 24, 2014
Closed
@ichernev
Copy link
Contributor

I know this is a bit outdated, but if we remove the hack for locale autoloading, what will happen with node users? Should we release a node-only version that autoloads, or not autoload, or have a one liner plugin that autoloads?

@marwahaha
Copy link
Member

See https://momentjs.com/docs/#/-project-status/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Breaking change Enhancement Up-For-Grabs
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
3 participants
@icambron @ichernev @marwahaha